Skip to content

travis: Test with Go 1.10 #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 8, 2018
Merged

travis: Test with Go 1.10 #764

merged 2 commits into from
Mar 8, 2018

Conversation

julienschmidt
Copy link
Member

Description

Adds Go 1.10 to the versions Travis tests against.
Although we agreed to only support the latest 3 Go versions, I didn't remove Go 1.7 yet.
Instead, I would postpone it until shortly after the v1.4.0 release.

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

@julienschmidt julienschmidt added this to the v1.4.0 milestone Mar 3, 2018
Copy link
Member

@methane methane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you test gofmt only on Go 1.10?

@julienschmidt
Copy link
Member Author

Done

@methane
Copy link
Member

methane commented Mar 8, 2018

LGTM.

@julienschmidt julienschmidt merged commit bcaf977 into master Mar 8, 2018
@julienschmidt julienschmidt deleted the go110 branch March 8, 2018 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants